search

airbytehq / PyAirbyte

PyAirbyte brings the power of Airbyte to every Python developer.
https://docs.airbyte.com/pyairbyte
Other
178 stars 20 forks source link

Chore(tools): Align Pyright configuration with MyPy and specific deterministic venv location for Pyright #176

Closed natikgadzhi closed 3 months ago

natikgadzhi commented 3 months ago

What

The only meaningful change is adding tool.pyright config in pyproject.toml, so that PyRight can see the .venv and resolve imports.

Side-effect: formatted pyproject.toml.

I don't have a very strong opinion. This makes my life easier as Zed doesn't do mypy. But, mypy and Pyright are not quite the same and have slighly different rules, and using PyRight should not be endorsed, and/or Pyright correctness is not guaranteed as far as I understand.

But, I don't think this will hurt us in any way. ;)

natikgadzhi commented 3 months ago

I thought poetry should be able to pick up that setting from pyproject.toml, but I remember it was a PITA.