search

airbytehq / PyAirbyte

PyAirbyte brings the power of Airbyte to every Python developer.
https://docs.airbyte.com/pyairbyte
Other
178 stars 20 forks source link

Fix: Add `json` fall back for deeply nested records #178

Closed SebastienN15 closed 2 months ago

SebastienN15 commented 2 months ago

orjson.dumps(some_dict) raises with TypeError: Recursion limit reached a when dumping a heavily nested dict This PR adds a fall back to use json.dumps(some_dict) instead, that can support much more nested dicts.

aaronsteers commented 2 months ago

/fix-pr

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

aaronsteers commented 2 months ago

/test-pr

PR test job started... Check job output.

❌ Tests failed.

aaronsteers commented 2 months ago

/fix-pr

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

aaronsteers commented 2 months ago

/test-pr

PR test job started... Check job output.

✅ Tests passed.

aaronsteers commented 2 months ago

@SebastienN15 - We have tests and lint checks passing. In the long run, I'd like to add unit tests and logging, but as-is, this seems ready to go, no reason not to merge. :shipit:

A great addition, and much appreciated.

Thanks again for contributing! 🙏