airbytehq / PyAirbyte

PyAirbyte brings the power of Airbyte to every Python developer.
https://docs.airbyte.com/pyairbyte
Other
215 stars 31 forks source link

💡 Feature Request: Add a prefix for cache table name #199

Open jiangsong216 opened 5 months ago

jiangsong216 commented 5 months ago

The cache table name is now just the data stream name, which cases conflicts if different data source has the same data stream name. It would be nice to add a prefix for cache table name.

jiangsong216 commented 5 months ago

Besides, I would like to add this feature if possible

aaronsteers commented 5 months ago

@jiangsong216 - Thanks very much for submitting this issue. Are you thinking that we would default the prefix to the name of the source - so that instead of a default table name of issues, we'd get something like github_issues?

I've been thinking about this too and we logged something (below) quite a while back but haven't been able to prioritize it.

If you still would like to contribute, can you confirm the proposed spec details? If the proposal lines up with long-term plans, I'd happily add the accepting pull requests label and invite you to contribute the feature/enhancement if you have time.

Relates to:

cc @bindipankhudi - since we were recently discussing this.

jiangsong216 commented 5 months ago

I found that we can specify a prefix or suffix explicitly when creating a cache, so my problem is solved

As for adding a default prefix for cache tables, can we simply include some source_name in sql.base.get_sql_table_name like this?

微信图片_20240429155446