search

airbytehq / airbyte-python-cdk

The Python CDK empowers hundreds of Airbyte connectors, including low-code and no-code connectors.
https://airbytehq.github.io/airbyte-python-cdk/
MIT License
0 stars 0 forks source link

Instantiate one stream per thread #21

Closed maxi297 closed 1 day ago

maxi297 commented 2 days ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 days ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes introduced in this pull request enhance the `ConcurrentDeclarativeSource` and `CursorPartitionGenerator` classes by implementing a factory method for creating stream instances. A new method, `_new_stream_instance_factory`, is added to ensure unique stream instances per thread, preventing concurrent modifications. The `CursorPartitionGenerator` constructor is updated to accept a `stream_factory` callable instead of a direct stream instance, promoting better flexibility. Corresponding updates are made to the test cases to reflect these changes in variable naming and instantiation. ## Changes | File Path | Change Summary | |----------------------------------------------------|-------------------------------------------------------------------------------------------------| | airbyte_cdk/sources/declarative/concurrent_declarative_source.py | Added method `_new_stream_instance_factory` to create unique stream instances per thread. Updated `_group_streams` to use the new factory method. Added import for `Callable`. | | airbyte_cdk/sources/streams/concurrent/adapters.py | Updated `CursorPartitionGenerator` to use `stream_factory: Callable[[], Stream]` instead of `stream: Stream` in the constructor. Adjusted documentation and imports accordingly. | | unit_tests/sources/streams/concurrent/test_adapters.py | Renamed `stream` variable to `stream_factory` in `test_cursor_partition_generator` to match changes in `CursorPartitionGenerator`. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant Thread participant ConcurrentDeclarativeSource participant CursorPartitionGenerator Thread->>ConcurrentDeclarativeSource: Request new stream instance ConcurrentDeclarativeSource->>ConcurrentDeclarativeSource: Call _new_stream_instance_factory() ConcurrentDeclarativeSource->>Thread: Return stream_factory Thread->>CursorPartitionGenerator: Instantiate with stream_factory CursorPartitionGenerator->>CursorPartitionGenerator: Generate stream using stream_factory() ``` > 🐇 "In the land of streams, where rabbits play, > A factory blooms, brightening the day. > No more shared states, each thread gets its own, > With unique little streams, our joy has grown! > Hopping through code, we dance with delight, > In the world of adapters, everything's right!" 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
aaronsteers commented 2 days ago

@maxi297 - I pulled in the latest from main, fyi.

maxi297 commented 1 day ago

Implemented as part of https://github.com/airbytehq/airbyte-python-cdk/pull/39/commits/ddd299ea9c0d0819ad37ecdbb2a820486880e882