airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
16.12k stars 4.12k forks source link

Add connector test that validates that the spec uses "valid" JSONSchema #12330

Closed cgardens closed 1 year ago

cgardens commented 2 years ago

Problem

For the spec of a connector, we allow the usage of a subset of the functionality that JSONSchema provides. When a spec uses a disabled JSONSchema feature it results in perplexing errors.

Proposed Solution

Put this in OSS Platform and Sources DX backlogs as it will be a quality of life improvement for both.

@sherifnada @evantahler @bleonard for visibility.

sherifnada commented 2 years ago

@cgardens is the allowed subset of json schema described anywhere? I tried documenting as much as i know here over time but I'm not sure if there are other limitations/features.

cgardens commented 2 years ago

So far the subset I have in mind is:

sherifnada commented 1 year ago

cc @flash1293 related to your interest in additional SATs for the frontend

flash1293 commented 1 year ago

Thanks, missed this issue. I copied over all context to https://github.com/airbytehq/airbyte/issues/20063 , closing this to consolidate