search

airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
16.33k stars 4.16k forks source link

Source Facebook Marketing: add `leads` stream #15507

Open vijaybridgeme opened 2 years ago

vijaybridgeme commented 2 years ago

Tell us about the problem you're trying to solve

https://developers.facebook.com/docs/marketing-api/guides/lead-ads/retrieving

This is facebook leads data. It shows in Facebook Ads page like this:

See attached image.

It is not clear if Airbyte downloads this data. It is probably not part of AdsInsight. Can you please confirm oneway or another and enable syncing that data.

Describe the solution you’d like

Can you please confirm oneway or another and enable syncing that data.

Describe the alternative you’ve considered or used

None

Additional context

image

Are you willing to submit a PR?

Probably

natalyjazzviolin commented 2 years ago

Hi @vijaybridgeme, you can find all supported endpoints right here: https://docs.airbyte.com/integrations/sources/facebook-marketing/#supported-tables

On-Facebook Leads are not supported. Support can be added by adding a stream specific to that endpoint. Would you be interested in contributing a PR?

vijaybridgeme commented 2 years ago

I can have our engineer work with you, if you can provide clear pointers on how to get this done.

natalyjazzviolin commented 2 years ago

I will need some time to create a list of clear pointers, but this would be a good place for your engineer to start: https://docs.airbyte.com/connector-development/tutorials/building-a-python-source

vijaybridgeme commented 2 years ago

Seems more complicated than I thought. We won't be able to contribute in the short term.

The best way is to have a commit with similar change.. so devs can have something as a reference. Without that, it will be very steep learning curve to contribute.

vijaybridgeme commented 2 years ago

I see "conversion" and "conversion_values" which is a JSON, in Airbyte tables. But in two sources we have connected, I don't see values. Can you please confirm that Airbyte downloads them?

They show up like this in FB Ads Manager.

Screen Shot 2022-08-10 at 5 17 28 PM

Thank you!

natalyjazzviolin commented 2 years ago

@vijaybridgeme let's move the discussion over to our forum to keep this feature request as clear as possible. Please create a new topic and we'll be able to assist you with all your questions: https://discuss.airbyte.io/

vijaybridgeme commented 2 years ago

Hi all,

there has been no response on discuss: https://discuss.airbyte.io/t/source-facebook-marketing-add-leads-stream/2274

Perhaps you guys can add "leads" stream yourself?

Thanks! Vijay.

natalyjazzviolin commented 2 years ago

Hi @vijaybridgeme , this is not currently a priority on our roadmap so I can't give you a timeline on this stream will be created. Perhaps someone else from the community might be interested in this stream as well and can submit a PR.

scottleechua commented 1 year ago

@sajarin I could have a look at this!

aline-tg commented 1 year ago

Hello everyone! Do you have a date to add this in Airbyte?

YowanR commented 1 year ago

@scottleechua Are you still interested in this one? @aline-tg No timelines yet but please +1 this issue to help us prioritize :)

YowanR commented 1 year ago

Note: We expect this stream to be incremental :)

scottleechua commented 1 year ago

@YowanR , yes, I'd like to have a look. :)

dis-sid commented 9 months ago

Should this be a PR on the existing Facebook marketing source connector or a new connector entire ?

NAjustin commented 5 months ago

Has anyone in this thread worked on a version of this yet? We have an old CDK connector version of this functionality, but I'm a little unclear what the blocker has been on this since it's a pretty popular feature and it seems like there's been good interest here.

If you started in and didn't complete it, what was the blocker?