Closed jrhizor closed 3 years ago
File upload support might be equally good as text areas for this.
Just noticed @jrhizor @cgardens we have here secret + multine, how are we going to handle such case? In case of multiline + secret - should we make it visible when you specify it and masked with *
when you edit? What's the expected behaviour?
good question.
should we make it visible when you specify it and masked with * when you edit
i think your suggestion is good.
@cgardens are we ready to change the type of the input in the appstore source to multiline?
@sherifnada it's on master but not on an officially released version. so your call on how you want to roll it out. thinking about it now this isn't going to be backwards compatible 😭
This issue was closed by accident. We should upgrade the appstore connector to use this by adding multiline: true
to the key spec.
Tell us about the problem you're trying to solve
Currently the appstore connector fails because when pasting a file into the
private_key
field removes the newlines, and the underlying library requires the newlines to handle the file.Describe the solution you’d like
Allow configuring multiline text inputs in specs, example:
Support
textarea
inputs in the UI formultiline
that propagate the newline characters in the UI.Bump the version of the appstore connector so the resulting
tap_config.json
files look like:Describe the alternative you’ve considered or used
I considered re-adding the newlines in files, but this seems buggy and doesn't address the general concern.