search

airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
16.13k stars 4.12k forks source link

Do not show Free Connector Program banner on GA connections #24211

Closed nataliekwong closed 1 year ago

nataliekwong commented 1 year ago

We show the free connector program on connections where both the source and destination are in GA. This should be excluded from having a banner as there is no benefit to the user to enrolling in FCP for those connections.

nataliekwong commented 1 year ago

Per @tealjulia 's suggestion, if we are going to only be showing this for Free Connector-eligible connections, the verbiage on this banner when displayed on a Connection's page can be modified to:

Enroll in the Free Connector Program to use this connector for free.

Screenshot 2023-04-17 at 11.46.51 AM.png

teallarson commented 1 year ago

See also this Slack message

josephkmh commented 1 year ago

Currently the enrollment banner is only shown on eligible connections, so I'm not quite sure what we want to do here? Is this related to the connection setup flow, or do we not want to show the FCP banners there at all? (as they might distract from completing the connection setup)

teallarson commented 1 year ago

Currently the enrollment banner is only shown on eligible connections, so I'm not quite sure what we want to do here?

Reopening the Slack thread with @nataliekwong might be worthwhile to ensure we've hit all the pieces she was hoping for. That said, the initial intent was fulfilled after merging this PR to fix the bug where I removed the enrollment banner from the connection page entirely.

nataliekwong commented 1 year ago

Yep, the crux of the issue is solved already by removing the banner from GA connections. Two small improvements that could be done:

Screenshot 2023-05-22 at 8 50 49 AM With the new header on connections, we no longer show the Alpha/Beta of the source/destination, so people see the banner only for FCP-eligible connections, but it doesn't indicate to them here why that banner shows up. Support also raised that it would be nice to bring back the alpha/beta badges here in some way and I think this is another reason why.

We also don't show the FCP banner on source/destination pages. Below I have a destination that is in beta, but no CTA for enrollment in FCP here. I think it would be consistent to show the banner on connections, sources, and destinations. Screenshot 2023-05-22 at 8 47 58 AM And small nit here: under "Overview" it says "connection" - should that be "Connections"?

josephkmh commented 1 year ago

Refining notes: