search

airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
14.97k stars 3.85k forks source link

[helm] Support overriding the minio/mc image #34825

Open Meir017 opened 5 months ago

Meir017 commented 5 months ago

Helm Chart Version

0.50.47

What step the error happened?

Other

Revelant information

The image configuration for the minio/mc image is hardcoded here https://github.com/airbytehq/airbyte-platform/blob/a66da101724ca8681577ffaa17bc708c3088be85/charts/airbyte/templates/minio.yaml#L95C1-L96C1

We should provide default image configuration in the values.yaml file, allowing to override the repository and image (same as we have for image: "{{ .Values.minio.image.repository }}:{{ .Values.minio.image.tag }}"

Relevant log output

No response

alanbrito commented 1 month ago

Any update here? We are unable to run airbyte on an on-prem k8s cluster because we can only pull from internal docker registries.

mikko-rvvup commented 2 weeks ago

This was very annoying discovery when hitting docker hub rate limits and not being able to use ECR for this image: https://docs.docker.com/docker-hub/download-rate-limit/