search

airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
15.76k stars 4.04k forks source link

[source-iterable] does not work for the EU iterable API #39488

Open rob-meisterlabs opened 3 months ago

rob-meisterlabs commented 3 months ago

Connector Name

source-iterable

Connector Version

0.3.0

What step the error happened?

Configuring a new connector

Relevant information

Source Iterable does not work on the eu api https://api.eu.iterable.com/api.

Relevant log output

No response

Contribute

marcosmarxm commented 3 months ago

Today the connector is using a hard-code API value https://github.com/airbytehq/airbyte/blob/39b3feeac514ecc70fb2d50a13a42af045b96a35/airbyte-integrations/connectors/source-iterable/source_iterable/streams.py#L34

The best strategy here probably is to introduce a new parameter in the connector specification, like region, to make the change of domain for the user.

Let me know if you need any helping doing the change @rob-meisterlabs feel free to ping me on slack

JaydanPB commented 2 days ago

Just a heads up. I addressed this issue with https://github.com/airbytehq/airbyte/pull/44508

We've had it working internally for several weeks without any issues. My PR never made it through community-ci testing for whatever reason, but the EU fix is there for whoever wants to chase it up.