search

airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
15.79k stars 4.05k forks source link

Platform should validate an entered cron expression to align frontend and backend error handling #40715

Open hongbo-miao opened 3 months ago

hongbo-miao commented 3 months ago

Topic

airbyte-webapp

Relevant information

Currently 0 0 15 * * 1 shows valid in the UI, but it is not. The good thing is when you click "save changes", it shows invalid.

The correct one is 0 0 15 ? * 1.

It will be great to let the UI shows invalid for 0 0 15 * * 1 as well. 😃

image

https://www.javainuse.com/cron is good resource to validate whether it is actually valid.

You can see 0 0 15 * * 1 is invalid: image

You can see 0 0 15 ? * 1 is invalid:

image

nataliekwong commented 3 months ago

The frontend sees this as valid but the backend does not. One solution would be to create a backend endpoint that validates the cron, and only show the preview if the validation passes.

Internal issue with additional user feedback: https://github.com/airbytehq/airbyte-internal-issues/issues/5069