Closed natikgadzhi closed 2 weeks ago
After a good discussion with @inossidabile, we decided that doing /poetry-lock
might be too wide and dangerous with unexpected consequences, so instead we will use /upgrade-cdk
with specific CDK version provided.
As a prerequisite, there is an internal repo issue to get the current implementation of airbyte-ci upgrade-cdk
command to work with Poetry-based connectors: https://github.com/airbytehq/airbyte-internal-issues/issues/8648
Assuming this gets done, the slash command for this issue would wrap that airbyte-ci command.
Since most connectors are moving to manifest-only, this is suddenly much lower value.
Problerm
Sometimes we'd need to change a version of the CDK in a PR from a community engineer, and now we need to run poetry lock for the PR to be good. It's additional back and forth and it would be good to automate it away, just like
/format-fix
.Solution
A new slash command! Initially we thought of
/poetry-lock
, but decided against it:So instead, we'll implement
/upgrade-cdk
command that takes a PR and version in, and:poetry add airbyte-cdk@VERSION
orlatest
.poetry lock --no-update
to ensure no other dependencies drift.How to build it
/format-fix
as an exampleairbyte-ci upgrade-cdk
on them