airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
15.39k stars 3.97k forks source link

Make `/upgrade-cdk version={VERSION}` slash command #41070

Closed natikgadzhi closed 2 weeks ago

natikgadzhi commented 1 month ago

Problerm

Sometimes we'd need to change a version of the CDK in a PR from a community engineer, and now we need to run poetry lock for the PR to be good. It's additional back and forth and it would be good to automate it away, just like /format-fix.

Solution

A new slash command! Initially we thought of /poetry-lock, but decided against it:

A command that takes the changes in the PR, and for all python packages that have changes in this pull request, it runs poetry lock, and commits the resulting changes back to the PR.

So instead, we'll implement /upgrade-cdk command that takes a PR and version in, and:

How to build it

natikgadzhi commented 1 month ago

After a good discussion with @inossidabile, we decided that doing /poetry-lock might be too wide and dangerous with unexpected consequences, so instead we will use /upgrade-cdk with specific CDK version provided.

As a prerequisite, there is an internal repo issue to get the current implementation of airbyte-ci upgrade-cdk command to work with Poetry-based connectors: https://github.com/airbytehq/airbyte-internal-issues/issues/8648

Assuming this gets done, the slash command for this issue would wrap that airbyte-ci command.

natikgadzhi commented 2 weeks ago

Since most connectors are moving to manifest-only, this is suddenly much lower value.