airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
15.88k stars 4.07k forks source link

airbyte-ci tool incorrectly errors out if airbytehq/airbyte is not one of the remote repositories #42837

Closed jettdc closed 2 months ago

jettdc commented 2 months ago

Topic

airbyte-ci

Relevant information

See here: https://github.com/airbytehq/airbyte/blob/a7fb873ba6dfe224a1f62c234e97eda73e323705/airbyte-ci/connectors/pipelines/pipelines/cli/ensure_repo_root.py#L14

If airbytehq/airbyte is not listed as a repo remote, then the airbyte-ci tool exits. I'm working on a fork of the repo and this was not automatically set for me when I cloned the repo, meaning I had to manually go in and add:

git remote add airbyte https://github.com/airbytehq/airbyte.git

which is fine but it should either:

since I needed to dig through the code to find this

natikgadzhi commented 2 months ago

Doesn't the warning message below the line you linked show up?

Airbyte CI is by design highly coupled with this repo. It's not ideal, but it helped us move quickly early on. Ideally, of course, we should make it repository agnostic. In the meantime, a PR with a better warning would be welcome.