search

airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
16.12k stars 4.12k forks source link

Airbyte metrics helm issue while passing imagePullSecret #42932

Open talha-naeem1 opened 3 months ago

talha-naeem1 commented 3 months ago

Helm Chart Version

0.63

What step the error happened?

On deploy

Relevant information

I had to pass imagepullsection in values file like this:

global:
  imagePullSecrets:
    - name: "ghcr-secret"

While i was installing helm chart i was getting this issue: image

Relevant log output

Error: YAML parse error on airbyte/charts/metrics/templates/deployment.yaml: error converting YAML to JSON: yaml: line 25: did not find expected key
helm.go:84: [debug] error converting YAML to JSON: yaml: line 25: did not find expected key
YAML parse error on airbyte/charts/metrics/templates/deployment.yaml
helm.sh/helm/v3/pkg/releaseutil.(*manifestFile).sort
    helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:146
helm.sh/helm/v3/pkg/releaseutil.SortManifests
    helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:106
helm.sh/helm/v3/pkg/action.(*Configuration).renderResources
    helm.sh/helm/v3/pkg/action/action.go:168
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
    helm.sh/helm/v3/pkg/action/install.go:304
main.runInstall
    helm.sh/helm/v3/cmd/helm/install.go:306
main.newTemplateCmd.func2
    helm.sh/helm/v3/cmd/helm/template.go:95
github.com/spf13/cobra.(*Command).execute
    github.com/spf13/cobra@v1.7.0/command.go:940
github.com/spf13/cobra.(*Command).ExecuteC
    github.com/spf13/cobra@v1.7.0/command.go:1068
github.com/spf13/cobra.(*Command).Execute
    github.com/spf13/cobra@v1.7.0/command.go:992
main.main
    helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
    runtime/proc.go:250
runtime.goexit
    runtime/asm_amd64.s:1598
talha-naeem1 commented 3 months ago

https://github.com/airbytehq/airbyte-platform/pull/346 I have figured out its solution as well. @octavia-squidington-iii pls review this

shadaab007 commented 3 months ago

@talha-naeem1 I am facing the same issue.

muneeb-mubashir commented 3 months ago

I am facing this issue since a year. If anyone can help, it would be great!

marcosmarxm commented 3 months ago

I requested to the deployment team take a look into this.