airbytehq / airbyte

The leading data integration platform for ETL / ELT data pipelines from APIs, databases & files to data warehouses, data lakes & data lakehouses. Both self-hosted and Cloud-hosted.
https://airbyte.com
Other
16.31k stars 4.16k forks source link

[helm] Template not using secret keys to recover Host, Port and Database #45949

Open matheusnd opened 2 months ago

matheusnd commented 2 months ago

Helm Chart Version

1.0.0

What step the error happened?

On deploy

Relevant information

Values file:

postgresql:
  enabled: false

global:  
  database:
    type: external
    secretName: airbyte-config-secrets
    portSecretKey: database-port
    databaseSecretKey: database-host
    userSecretKey: database-user
    passwordSecretKey: database-password

This deploy is failing due to the missing keys: host, port and database If the secret keys are define, it was supposed to get from the secret instead of the values file.

Relevant log output

Error: INSTALLATION FAILED: execution error at (airbyte/templates/env-configmap.yaml:34:6): You must set `global.database.port` when using an external database
marcosmarxm commented 2 months ago

https://github.com/airbytehq/airbyte/pull/45951 fix the docs. I'm going to keep this issue to fix the charts. Thanks for reporting the problem @matheusnd