Closed jdpgrailsdev closed 1 day ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
airbyte-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 22, 2024 6:03pm |
this looks a lot like https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/bulk/core/load/src/main/kotlin/io/airbyte/cdk/load/data/AirbyteTypeToAirbyteTypeWithMeta.kt ? which we can maybe reuse in some way
this looks a lot like https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/bulk/core/load/src/main/kotlin/io/airbyte/cdk/load/data/AirbyteTypeToAirbyteTypeWithMeta.kt ? which we can maybe reuse in some way
@edgao It does and I wasn't sure how to reuse that given that it returns Airbyte types and not Iceberg types. I suspect what is really being pointed out here is some refactor to this in the CDK to make the common parts more common.
PR has been updated to validate that the metadata is added to the schema. I have removed the code that I originally added to do this, as the existing logic already adds the fields. This is confirmed via new tests added to this PR.
What
How
withMetadata()
is calledIcebergUtil
to a Micronaut singleton to better facilitate testingReview guide
IcebergUtil.kt
IcebergUtilTest.kt
IcebergV2WriterTest.kt
AirbyteTypeToAirbyteTypeWithMetaTest.kt
Can this PR be safely reverted and rolled back?