eliziario
commented
3 years ago Connector currently supports api_key.
Zendesk sunshine access tokens don't expire,
- add authorization property to spec with options api_key or oauth.
- implement receiving secret code and grant access token.
- implement using obtained access tokens to fetch resources.
VasylLazebnyk
Tell us about the problem you're trying to solve
With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.
If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. There are two ways to do this:
If the connector already supports some auth mechanism like api_key, I suggest that this be a oneof nested inside a top-level field called "authentication":
{ authentication: { type: object oneOf: [ // api key, // oauth ] } }If the connector only supports webflow oauth, then no changes are needed to the properties format and we will only need to add annotations.
See the connector spec reference in the docs for reference on how a oneof can be implemented.
This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.
Acceptance Criteria