search

airbytehq / glossary

Data Glossary 🧠: An interactive digital garden for deeper data exploration. Learn through a graph and backlinks, enabling layered knowledge discovery.
https://glossary.airbyte.com
MIT License
98 stars 13 forks source link

links in private folder will be rendered #9

Closed JeffeyChou closed 1 year ago

JeffeyChou commented 1 year ago

Describe the bug I enable the enableGlobalGraph in graphConfig.yaml, and my graph view in home page into a mess: the links of private notes in private folder would also be rendered, which is I unexpected. Thankfully, the notes in private folder are still unreachable.

To Reproduce Steps to reproduce the behavior:

  1. Add some md notes that contain markdown links which are based on the vault's path to the private folder.
  2. Go to graphConfig.yaml in data folder
  3. Enable the enableGlobalGraph option
  4. Render the page
  5. See error

Expected behavior The notes and their links in the private folder should not be rendered in the graph.

Screenshots image

Desktop (please complete the following information):

Additional context the link showed in the img has some error, that is when the file that the link refer to has been removed, the node in the graph denotes random code(that means the Chinese characters are not decoded by UTF-8).

Based on the info above, I think we use the detact method as the solution: if the link is bad(refer to 404 page), then skip rendering this link.

JeffeyChou commented 1 year ago

Its my fault, when switch branch to gh-page, all the link in private folder will not be rendered.

So this is a minor error instead of a bug 😂