search

airbytehq / terraform-provider-airbyte

Terraform Provider for Airbyte API
https://api.airbyte.com/
MIT License
45 stars 21 forks source link

Configure timeout of the http client #82

Open Jrmyy opened 7 months ago

Jrmyy commented 7 months ago

Hello,

Right now, it seems that there is a timeout of 60 seconds for the http client in the provider. (https://github.com/airbytehq/terraform-provider-airbyte/blob/6e55dd87be8c72bb7b6311783f79f3027b9ab20c/internal/sdk/sdk.go#L135)

According to the documentation (https://registry.terraform.io/providers/airbytehq/airbyte/latest/docs) it is not possible to override it.

Would it be possible to make it configurable ? If it is already possible, can you point me to the correct documentation please ?

Jrmyy commented 6 months ago

👋🏻 Hello I can see that a new release 0.4.2 has been made. Is this release contains the fix to this issue ?

szemek commented 4 months ago

@Jrmyy you should check 0.5.0 I got information from @ThomasRooney that fix is implemented https://github.com/airbytehq/terraform-provider-airbyte/blob/30913cb2a9007c7b03407f0160267908c38888a4/internal/provider/provider.go#L120 I use this version myself and I found in my project's CI pipelines that connections are successfully created, taking more than 60 seconds to create.

Jrmyy commented 4 months ago

Thanks a lot @szemek , I will take a look 🥳

Jrmyy commented 4 months ago

Now indeed there is no timeout anymore (since it uses the default http client) which solves my problem. Is there any plan to make the timeout configurable or not @ThomasRooney ?