impr(Documentation): Formatting

aircall / aircall-everywhere

SDK to embed and communicate to Aircall phone in any web page

https://aircall.github.io/aircall-everywhere

25 stars 16 forks source link

impr(Documentation): Formatting #8

Closed quentin-sommer closed 5 years ago

quentin-sommer commented 5 years ago

Formatting improvements

Addded save option to npm install commands

Also IMO the ap name is very close to traditional express-like servers app in the node.js community and might be confusing. How about changing it to something else? For example phone, aphone, aircallPhone

[x] Your branch is based on master
[x] Your code is unit tested
[x] CircleCI builds are green (coverage and lint)
[x] Add team "CTI" as "Reviewer" for the PR
[x] Name your PR with the convention fix|feat|impr(<subject>): description.

hereismass commented 5 years ago

Good idea :) Something as simple as phone can do the trick. I can do it if you want

quentin-sommer commented 5 years ago

As you want! I have time to do it too if you're busy

hereismass commented 5 years ago

I'm a bit busy, I can do it next week. If you have time before, be my guest!

quentin-sommer commented 5 years ago

@hereismass Ready to be reviewed!

hereismass-bot commented 5 years ago

The code coverage of this PR is 100% :white_check_mark: Coverage for master is 100%.

hereismass-bot commented 5 years ago

The code coverage of this PR is 100% :white_check_mark: Coverage for master is 100%.

hereismass-bot commented 5 years ago

The code coverage of this PR is 100% :white_check_mark: Coverage for master is 100%.

quentin-sommer commented 5 years ago

ping @hereismass can we ship this 😃?