search

airctic / icevision

An Agnostic Computer Vision Framework - Pluggable to any Training Library: Fastai, Pytorch-Lightning with more to come
https://airctic.github.io/icevision/
Apache License 2.0
849 stars 150 forks source link

Adding Non Unique Names To ClassMap Must Be Illegal #819

Closed rsomani95 closed 3 years ago

rsomani95 commented 3 years ago

Currently, add_name doesn't check if the added name is a duplicate or not. This should be illegal, as classes must be unique

https://github.com/airctic/icevision/blob/82f3c7322d5adbc41d6a1b7b9e4327eb32ad23c4/icevision/core/class_map.py#L47-L51

lgvaz commented 3 years ago

valid point! up for a PR rahuuuul? =)