search

airctic / icevision

An Agnostic Computer Vision Framework - Pluggable to any Training Library: Fastai, Pytorch-Lightning with more to come
https://airctic.github.io/icevision/
Apache License 2.0
849 stars 150 forks source link

Hardcoded version of mmdet #944

Open FrancescoSaverioZuppichini opened 3 years ago

FrancescoSaverioZuppichini commented 3 years ago

Hello there,

I hope you are doing great!

🐛 Bug

Describe the bug You hardcoded the version of mmdet -> https://github.com/airctic/icevision/blob/989e50a4c49a0505b5d340d1f585154c7f7e480f/icevision/models/mmdet/download_configs.py#L6

You should dynamically import mmdet and get the __version__ from it. This causes endless compatibility problems making icevision virtually impossible to use without forcing yourself to use a old version of mmdet (icevision release uses the 2.10.0).

Thank you!

Cheers,

Francesco

FraPochetti commented 2 years ago

@ai-fast-track do you know why we are doing this?

FraPochetti commented 2 years ago

@ai-fast-track wdyt?

dnth commented 2 years ago

From what i understand this line of code is used to import the config file version from this repo. It does not affect the mmdet version installed with IceVision.

The latest stable mmdet version that can run all models on IceVision is mmdet==2.17.0. I have tried mmdet==2.20.0 but VFNet model fails to run.