airdcpp-web / airdcpp-release-validator

AirDC++ extension that performs various validations for release directories
1 stars 3 forks source link

Feature Request: options to specify if a check should prevent bundle from being shared or just show in log #18

Open peps1 opened 3 years ago

peps1 commented 3 years ago

Right now when checking a bundle, if any of the validation checks fail the bundle is not shared.

As some checks though can be considered more FYI than others, like "no nfo" and "multiple nfo", it would be nice to have an option to tell it to still share those and just print the info about missing/multiple nfo to log.

Maybe just another toggle in the settings for each of these.

peps1 commented 3 years ago

i'm looking into this now, seems easiest way is to just change the current boolean settings to string and have 3 options.

image

@maksis: any concerns?

maksis commented 2 years ago

There will hopefully soon be new functionality that will allow blocked directories to be added in share manually. That will also include listeners that are fired when a directory is being blocked during refresh (this is already available for blocked finished bundles).

I'd prefer having a separate extension that can then handle the cases when the release validator detects that something is wrong. The best way to handle it might be to use an external release database to check whether the content is valid (and force such releases to be added share).