airdcpp-web / airdcpp-release-validator

AirDC++ extension that performs various validations for release directories
1 stars 3 forks source link

ANSI files with international characters #31

Open Sopor opened 2 years ago

Sopor commented 2 years ago

When the sfv file is in ANSI and contains Swedish characters it will fail to check.

image

First there are missing files and then there are extra files. It seems that the airdcpp-release-validator gets totally confused.

airdcpp-release-validator: Kenneth_and_The_Knutters-Bagrock_och_Motorvral_1982-1987-1989-GRiPP\: File listed in the SFV file does not exist on disk (4 file(s): 03-kenneth_&_the_knutters- nglab ge_( nglahund)-gripp.mp3, 04-kenneth_&_the_knutters- lgjaktsrapp-gripp.mp3, 08-kenneth_&_the_knutters-vi_ska_ha_v ra_b gar_kvar-gripp.mp3, 12-kenneth_&_the_knutters-st ll_p -gripp.mp3) 
airdcpp-release-validator: Kenneth_and_The_Knutters-Bagrock_och_Motorvral_1982-1987-1989-GRiPP\: Extra files in release directory (4 file(s): 03-kenneth_&_the_knutters-änglabåge_(änglahund)-gripp.mp3, 04-kenneth_&_the_knutters-älgjaktsrapp-gripp.mp3, 08-kenneth_&_the_knutters-vi_ska_ha_våra_bågar_kvar-gripp.mp3, 12-kenneth_&_the_knutters-ställ_på-gripp.mp3) 
airdcpp-release-validator: Following problems were found while scanning the bundle Kenneth_and_The_Knutters-Bagrock_och_Motorvral_1982-1987-1989-GRiPP: file listed in the SFV file does not exist on disk (count: 4), extra files in release directory (count: 4)

Most sfv files use ANSI and external sfv checkers have no problems to check it even if it contains Swedish chars, so why can't the airdcpp-release-validator handle it?

If this can't be fixed there should be some kind of option to make the airdcpp-release-validator skip sfv files it can't handle and report it, so the user can take care of it.

fohlsso2 commented 2 years ago

Even if a sfv contains file names that is not according to the current 'standards', the checker should still be able to correctly parse the file and not tag the files as missing.

maksis commented 1 year ago

Pull requests for handling non-utf8 encodings are welcome