search

airflow-helm / charts

The User-Community Airflow Helm Chart is the standard way to deploy Apache Airflow on Kubernetes with Helm. Originally created in 2017, it has since helped thousands of companies create production-ready deployments of Airflow on Kubernetes.
https://github.com/airflow-helm/charts/tree/main/charts/airflow
Apache License 2.0
647 stars 475 forks source link

Enabling gitsync and PVC should work #741

Closed ekdeveloper closed 1 year ago

ekdeveloper commented 1 year ago

Checks

Chart Version

8.7.0

Kubernetes Version

NA

Helm Version

8.7.0

Description

airflow doc says the both gitsync and pvc can be enabled https://airflow.apache.org/docs/helm-chart/stable/manage-dags-files.html#mounting-dags-using-git-sync-sidecar-with-persistence-enabled

https://github.com/apache/airflow/blob/97215822f90cac274e92e642fcd724cc940fe0eb/chart/templates/dag-processor/dag-processor-deployment.yaml#L135

however there is a validation check to prevent this https://github.com/airflow-helm/charts/blob/f5c2f0cd617982c642789cf66fdef48453f84e67/charts/airflow/templates/_helpers/validate-values.tpl#LL122C1-L122C1

Relevant Logs

No response

Custom Helm Values

No response

thesuperzapper commented 1 year ago

@ekdeveloper the docs you are referencing are for a different helm chart. This helm chart (the User-Community one) is planning to implement support for having both git-sync and PVC persistence soon (see https://github.com/airflow-helm/charts/issues/283), but this change has not yet been merged, hence the values-validation which prevents it for now.