search

airflow-helm / charts

The User-Community Airflow Helm Chart is the standard way to deploy Apache Airflow on Kubernetes with Helm. Originally created in 2017, it has since helped thousands of companies create production-ready deployments of Airflow on Kubernetes.
https://github.com/airflow-helm/charts/tree/main/charts/airflow
Apache License 2.0
630 stars 474 forks source link

fix: liveness probes in airflow 2.6.0 #743

Closed thesuperzapper closed 1 year ago

thesuperzapper commented 1 year ago

What issues does your PR fix?

What does your PR do?

This PR fixes support for airflow 2.6.0 in the chart. Due to PR https://github.com/apache/airflow/pull/30302, airflow's Job objects SchedulerJob and TriggererJob were changed so they are now wrapped in an XXXXJobRunner object, which broke our scheduler and triggerer liveness probes.

There is a related upstream airflow issue https://github.com/apache/airflow/issues/31200 introduced by Airflow 2.6.0 (which can't really be fixed by this chart), the details of that issue are explained in https://github.com/apache/airflow/issues/31200#issuecomment-1546765025, so you should strongly consider waiting for at least 2.6.1 before upgrading.

After this PR the liveness probes for the scheduler and triggerer will not always fail.

Checklist

For all Pull Requests