feat: add s3-sync sidecar option (breaking values changes)

airflow-helm / charts

The User-Community Airflow Helm Chart is the standard way to deploy Apache Airflow on Kubernetes with Helm. Originally created in 2017, it has since helped thousands of companies create production-ready deployments of Airflow on Kubernetes.

https://github.com/airflow-helm/charts/tree/main/charts/airflow

Apache License 2.0

630 stars 474 forks source link

feat: add s3-sync sidecar option (breaking values changes) #782

Open benchoncy opened 10 months ago

benchoncy commented 10 months ago

What issues does your PR fix?

fixes #249

What does your PR do?

Note: This PR suggests interface changes with dags.gitSync values. May need to be viewed in the context of #501.

Generalises the definition of gitSync to a general sync pod definition
Refactor dags.gitSync values to dags.sync
Add support for s3 sync under new dags.sync values
Amend value validation for gitSync and add new validation for s3
Update README to reflect changes

Checklist

For all Pull Requests

[x] Commits are signed off
[x] Commits have semantic messages
[x] Documentation updated
[x] Passes ct linting

For releasing ONLY

[ ] Chart.yaml version bumped
[ ] CHANGELOG.md updated

jdobyns commented 7 months ago

Whats the hold up on this?

stale[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had activity in 60 days. It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.

Issues never become stale if any of the following is true:

they are added to a Project
they are added to a Milestone
they have the lifecycle/frozen label

benchoncy commented 1 month ago

@thesuperzapper Considering there is now a competing pull request for the same feature #828, which appears to have gotten more discussion, should I close this pull request? There are now conflicts, so I'm looking to determine if this is worth updating.

thesuperzapper commented 1 month ago

@benchoncy I really do appreciate the effort you have put in.

However, I am exceptionally unlikely to release any breaking changes in the values for the foreseeable future, as it's just too much work for people to migrate.

If you think you can do a better job then the other PR at adding new values specifically for S3 (or something similar), then you're welcome to either update this PR or make a new one.