airflow-helm / charts

The User-Community Airflow Helm Chart is the standard way to deploy Apache Airflow on Kubernetes with Helm. Originally created in 2017, it has since helped thousands of companies create production-ready deployments of Airflow on Kubernetes.
https://github.com/airflow-helm/charts/tree/main/charts/airflow
Apache License 2.0
665 stars 476 forks source link

feat: configurable pgbouncer replicas #813

Closed crabio closed 8 months ago

crabio commented 11 months ago

What issues does your PR fix?

no fixes

What does your PR do?

added possibility to set multiple pgbouncer replicas

Checklist

For all Pull Requests

For releasing ONLY

crabio commented 11 months ago

Needed same change as done in Official Helm chart: https://github.com/apache/airflow/pull/27439/files/ed3b520a97152f2f750c3e682eb5d2749810bbc9

crabio commented 11 months ago

@thesuperzapper May you review my small fix, please?

stale[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had activity in 60 days. It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label
thesuperzapper commented 8 months ago

You cant actually run multiple replicas of pgbouncer (at least, not without actually making HA worse):

See https://github.com/airflow-helm/charts/issues/622#issuecomment-1244770340