Patch for IPv6 native clusters (airflow binds to ipv4 only by default)

airflow-helm / charts

The User-Community Airflow Helm Chart is the standard way to deploy Apache Airflow on Kubernetes with Helm. Originally created in 2017, it has since helped thousands of companies create production-ready deployments of Airflow on Kubernetes.

https://github.com/airflow-helm/charts/tree/main/charts/airflow

Apache License 2.0

630 stars 474 forks source link

Patch for IPv6 native clusters (airflow binds to ipv4 only by default) #845

Closed xorl closed 2 months ago

xorl commented 2 months ago

What issues does your PR fix?

-fixes IPv6 native clusters cannot be reached on IPv4 addresses.

What does your PR do?

This PR makes the following changes... Adds --hostname [::] to the exec airflow webserver command so that it binds to ipv6 as well as ipv4.

Checklist

For all Pull Requests

[x] Commits are signed off
[x] Commits have semantic messages
[x] Documentation updated
[x] Passes ct linting

For releasing ONLY

[ ] Chart.yaml version bumped
[ ] CHANGELOG.md updated

xorl commented 2 months ago

@thesuperzapper @gsemet Any chance we can get a review for this simple change? It's mission critical for an OpenMetadata dependency to support this.

thesuperzapper commented 2 months ago

@xorl thanks for raising this, but it turns out you can set this already with the AIRFLOW__WEBSERVER__WEB_SERVER_HOST config, so we don't need to expose a new value for it.

For example, you might set the following values:

airflow:
  config:
    AIRFLOW__WEBSERVER__WEB_SERVER_HOST: "[::]"