search

airflow-helm / charts

The User-Community Airflow Helm Chart is the standard way to deploy Apache Airflow on Kubernetes with Helm. Originally created in 2017, it has since helped thousands of companies create production-ready deployments of Airflow on Kubernetes.
https://github.com/airflow-helm/charts/tree/main/charts/airflow
Apache License 2.0
665 stars 475 forks source link

extraEnv values are not templated, but docs suggest they are #879

Closed jessebye closed 3 months ago

jessebye commented 3 months ago

Checks

Chart Version

8.9.0

Kubernetes Version

Client Version: v1.30.3
Server Version: v1.29.6-eks-db838b0

Helm Version

version.BuildInfo{Version:"v3.15.4", GitCommit:"fa9efb07d9d8debbb4306d72af76a383895aa8c4", GitTreeState:"clean", GoVersion:"go1.22.6"}

Description

The chart documentation suggests that extraEnv values will be templated:

You can also utilize extraEnv and extraEnvFrom if you need the name or value to be templated.

However, those values do not get templated.

Relevant Logs

No response

Custom Helm Values

No response

thesuperzapper commented 3 months ago

@jessebye You are linking to the docs of a different chart.

However, I am open to allowing templating in the airflow.extraEnv values in this chart, I see that you have raised a PR to add this functionality, lets discuss it more there:

jessebye commented 3 months ago

@thesuperzapper oops, sorry about that - got the two mixed up. Yes let's discuss in the PR and I'll close this issue out 😄 thank you!