airfranceklm / ng-lazy-image

Angular directive for loading responsive image when container (which is preventing reflow) is in viewport.
http://afklm.github.io/ng-lazy-image/
MIT License
351 stars 64 forks source link

Update debounce with throttle in service #65

Closed barinali closed 7 years ago

barinali commented 7 years ago

Hi folks,

We're using this module in one of our projects. But we've a problem. Actually, our issue is opened here. When we're scrolling fast, images aren't being loaded. I think it's caused by debounce function. So I've update debounce function with throttle to solve this.

barinali commented 7 years ago

@SquadraCorse could you review this please if you're available?

By the way, this build has been failed. It's because of JSHINT. But there is no explained failure messages in reporter xml. So I couldn't understand anything. But I checked previous pull requests. As far as I see, it's a normal situation.

tuncaulubilge commented 7 years ago

We also need this fix

SquadraCorse commented 7 years ago

Im on holiday now, will merge when im back. The change looks valid, i will remove linting error myself no worries. Thanks for your time!

On 11 Nov 2016, at 12:47, Tunca Ulubilge notifications@github.com wrote:

We also need this fix

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.