search

airgap-it / airgap-coin-lib

A library that offers a unified API to prepare, sign and broadcast multiple cryptocurrencies.
https://airgap-it.github.io/airgap-coin-lib/
MIT License
143 stars 38 forks source link

Add BCH support #21

Open graciborski opened 3 years ago

graciborski commented 3 years ago

It should be fairly easy as it is almost the same as Bitcoin BTC

AndreasGassmann commented 3 years ago

Yes, integrating BCH would probably be very straight forward.

The reason we are hesitant to include bitcoin derivatives is because it opens a new attack surface where users can be tricked into signing a valid transaction that is masked as another currency. In this example, a BTC transaction could be displayed as a BCH transaction.

A vulnerability in many HW wallets was discovered a while ago that exploited this. It looks like BCH is not affected by this, but we'll still have to do some research to make sure we don't miss anything: https://donjon.ledger.com/lsb/014/

Nonetheless, we will discuss this internally.

graciborski commented 3 years ago

Yeah, better to be safe than sorry. Thanks for such a quick response!

AndreasGassmann commented 3 years ago

You're welcome. I will update this ticket when we have news.

graciborski commented 3 years ago

Hey there, any decisions made? :)