search

airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.
MIT License
380 stars 107 forks source link

Bug - shown wrong Coin name when dealing with MetaMask #151

Closed NawarKh closed 7 months ago

NawarKh commented 2 years ago

First of all, thanks for the nice work After trying it out with MetaMask Airgap vault in andorid Metamask in Iphone and according to " but the AirGap Vault is blockchain agnostic. It can sign transactions on any EVM chain by adding the RPC of that chain to MetaMask "

When sending BNB from Metamask and during the transmission authentication process Show currency name ethereum With the BNB transfer

the transfer was successful and there is no problem Only the name of the currency causes the sender some doubt, especially the difference between their price AAAAA

Thanks

AndreasGassmann commented 2 years ago

The only information the Vault has is the chainID to differentiate the different chains. We can probably add some of the well known chainIDs and map them to specific names and then show no name for the others.

Thanks for the suggestion, we will look into this for one of the next releases.

debeldami commented 7 months ago

As Andreas mentioned, the only information the Vault has is the chainID. So, it is unable to tell the sticker of the blockchain it's dealing with. In the future, we might consider hardcoding specific stickers to different chains. I will close this issue because it is old.