airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.
MIT License
380 stars 107 forks source link

Error working on Android 86X and question about Ethereum coming upgrade #155

Open NawarKh opened 1 year ago

NawarKh commented 1 year ago

Hello My first note before the question, I faced several problems and difficulties with the Android version, either because of the root condition, for example I decided to use a Flash memory with Android 86x instead of the phone The first problem was because the system is rooted, and I don't care about that because It will offline flash memory I modified the program manually by android studio , and I installed it again to skip root check, the button to confirm seed did not respond (last step after reconfirm new seed ) , the program does not respond when I press confirm and continue ( on Android x86 - flash memory) I tried with different mobile devices, and I noticed that many mobile devices have their own webview that cannot be changed without root The app did not work on it due to the use of a capacitor Therefore, I think that the project will not truly see the light until it is transferred to a completely separate app made by native JAVA Because you will find thousands of users complaining about the initial operation problems, because of Capacitor

Now the solution I used to work on my flash memory is to run the entire capacitor environment with npm run start And use it from a browser! On a Linux system loaded on a flash memory

The question is, there is a big upcoming update on the Ethereum network, the famous cold wallets are clarifying some details for their users, so what should we expect from airgap vault Will there be errors or problems? even with MetaMask

Thank you for this work, and I hope it will be soon more pubular

AndreasGassmann commented 1 year ago

Hi, thanks for giving AirGap a try.

Regarding your first questions, I don't really know what the issue is there. I think simply disabling the root check will have some unintended consequences in the secure storage, so I'm not sure it is as simple as just disabling it.

About the Ethereum upgrade, the current update will change from PoW to PoS, but it will not change anything for how users interact with the blockchain. So everything will continue to work automatically, no changes are necessary.

NawarKh commented 1 year ago

Thank you for the explanation I think the possibility of skip the root check is very important, I think, for example, that MetaMask is working on a rooted device It is sufficient to warn the user of the risks The idea of ​​the app is very nice, and it can be used on different systems, so forcing it to be not rooted , I don't think it will help anything, especially for an expert user, and secondly for those who are going to use it offline.

For example I didn't want to use an old phone, I prefer to use flash memory ( cheap 10$ ), it is better and will always be offline, this root test was tired to get over it , for me, without any benefit But thank you, and I hope soon that it will be converted into the native application, because many difficulties ,errors and failure to work appear on different devices, old and new, due to Webview


I will add an explanation for those who want to use flash memory for aiggap vault and how to use it (without disabling root check of airgap vault ) Until a clear version is released for Linux devices

Note : idea of ​​choosing the android version that support google play store , since these versions are not rooted by default, it is very important to skip the root check for Airgab vaulit without need to disable it manully

There are many other ways to use it in flash memory and linux, but I prefer this one at the moment