search

airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.
MIT License
380 stars 107 forks source link

Support Legacy transaction #157

Closed heisenberg-2077 closed 7 months ago

heisenberg-2077 commented 1 year ago

Currently when using Rabby and Airgap Vault, legacy transactions are sent by default. But now Airgap Vault does not support processing legcay transaction data. Do you have plans to support?

https://github.com/RabbyHub/Rabby/issues/924

AndreasGassmann commented 1 year ago

If I remember correctly, we do not handle legacy transactions because MetaMask only uses the newer format as far as I know.

We could look into supporting legacy transactions, but is there a reason why Rabby uses legacy transactions by default?

heisenberg-2077 commented 1 year ago

The default legacy transaction is for compatibility. Because Rabby supports many kinds of hardware wallets, some wallets do not support eip-1559 when the version is too low.

AndreasGassmann commented 1 year ago

As far as I'm aware, the only QR based signers are KeyStone and AirGap Vault. Both of which support EIP-1559. Would it be possible to change the default for QR based HW wallets to EIP-1559?

We can look into supporting legacy transactions, but ideally we should try to move the default to the newer standards in my opinion.