search

airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.
MIT License
390 stars 108 forks source link

Enumeration of BIP39 words are different than the standard #166

Closed AndresChapo closed 1 year ago

AndresChapo commented 1 year ago

I used BIP39 words list on AirGap vault to pass my seed phrase to numbers so I could write them in a steel wallet. Then I realize that other websites like the bitcoin repo, getcoinplate, Blockplate (the first 3 sites when you google "BIP39 words list"), starts counting with 1 = abandon, when the AirGap starts with 0 = abandon .

image image

I know it doesn't look like a big thing. But actually I was preparing that steel wallet to inherit it in case I pass away. so the person who will try to get back the words wouldn't find the right seed phrase.

I guess the solution would be some kind of advice in the app, or a switch button to see it the other way.

AndreasGassmann commented 1 year ago

Hi, thanks for reporting this issue. I think our list starts from 0 simply because we iterate over the array of words and arrays start at 0. But you are right, we should be consistent with the other lists, so we'll change that.

If you want, you can create a PR for it and we will merge it, otherwise I'll add it to our backlog.

AndresChapo commented 1 year ago

Nice! How can I submit a PR? I mean, I don't have permission for that.

AndreasGassmann commented 1 year ago

Nice!

How can I submit a PR? I mean, I don't have permission for that.

Hey, sorry, I'm just seeing this now.

To create a PR, you don't need any special permissions. You can basically just fork the repository and do the changes in our own repository, then create a PR to merge your changes into the main repository.

Let me know if you need any more help with this!

mlaeng commented 1 year ago

This has been changed in one of the last versions. I'll close this issue. Thanks for pointing it out!

image