search

airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.
MIT License
390 stars 108 forks source link

Remove android.enableJetifier line from gradle.properties & jetifier usage #177

Open emanuelb opened 1 year ago

emanuelb commented 1 year ago

https://github.com/airgap-it/airgap-vault/blob/22a8c5defa2f93524406b90b49f7c50e6e6cd71b/android/gradle.properties#L12

See this guide for the steps to ensure it's safe to remove above line android.enableJetifier=true (check that all deps are already fully migrated to AndroidX, and migrate the ones still not migrated to it) https://medium.com/dipien/say-bye-bye-to-android-jetifier-a7e0d388f5d6

Also remove lines of jetifier package installation and usage:

https://github.com/airgap-it/airgap-vault/blob/38a8eeff68adcb40102be9cdbab61d11e87e96ae/package.json#L26 https://github.com/airgap-it/airgap-vault/blob/38a8eeff68adcb40102be9cdbab61d11e87e96ae/package.json#L132 https://github.com/airgap-it/airgap-vault/blob/38a8eeff68adcb40102be9cdbab61d11e87e96ae/package.json#L155 https://github.com/airgap-it/airgap-vault/blob/38a8eeff68adcb40102be9cdbab61d11e87e96ae/package.json#L171 https://github.com/airgap-it/airgap-vault/blob/89b617d6aa01ac6dbe17d28114272e51923c199e/build/android/Dockerfile#L36 https://github.com/airgap-it/airgap-vault/blob/89b617d6aa01ac6dbe17d28114272e51923c199e/build/android/Dockerfile#L48

Related messages from compiling app:

$ jetifier && node apply-diagnostic-modules.js && node fix-qrscanner-gradle.js && yarn browserify-coinlib
Jetifier found 140 file(s) to forward-jetify. Using 1 workers...
$ /app/node_modules/.bin/jetifier
Jetifier found 140 file(s) to forward-jetify. Using 1 workers...