airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.
MIT License
390 stars 108 forks source link

Support URL Schema Redirect for Companion App #193

Open ifaouibadi opened 1 year ago

ifaouibadi commented 1 year ago

Issue Title Unable to redirect back to Superhero Wallet from AirGap Vault using deeplinking

Description Currently, we are facing an issue while implementing a connection between Superhero Wallet and AirGap Vault. We have successfully implemented QR code syncing, but we are unable to redirect back to Superhero Wallet from AirGap Vault using deeplinking. Upon investigation, we found that https://github.com/airgap-it/airgap-angular-components/blob/master/packages/core/src/lib/services/deeplink/deeplink.service.ts#L61 is hard coded to use airgap-wallet.

Expected Result We expect AirGap Vault to support callBackURL within the iacMessage or redirect to CompanionApp.urlSchema to enable seamless redirection back to Superhero Wallet. This will enable a smoother user experience and make the implementation process more convenient. It would be great if the AirGap team could consider implementing this functionality in a future release.

davidyuk commented 5 months ago

😢