Add .ipa file to github releases

airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.

MIT License

386 stars 109 forks source link

Add .ipa file to github releases #48

Open emanuelb opened 3 years ago

emanuelb commented 3 years ago

Github Releases contain .apk file in assets, please add a .ipa file as well. https://github.com/airgap-it/airgap-vault/releases

AndreasGassmann commented 3 years ago

In theory we could do that, but as I wrote in this issue on walletscrutiny, the .ipa is not reproducible.

I'm also not sure if you can sideload the ipa without using xCode, at which point you might as well just build the whole app yourself.

So what advantage would it bring if we released the .ipa file as well? If there is no use for it, it's just more work for us without any clear benefits.

emanuelb commented 3 years ago

I replied to the issue in walletscrutiny, you can read for more details about the benefits & why it's needed: https://gitlab.com/walletscrutiny/walletScrutinyCom/-/issues/149#note_537109159 short version is because I want to try reproducing it and look at the differences, and for that you need to publish the file...