search

airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.
MIT License
386 stars 109 forks source link

fix: don't break iteraction urls with a custom prefix #64

Open davidyuk opened 3 years ago

davidyuk commented 3 years ago

In the Base aepp, we are using a custom one: https://github.com/aeternity/aepp-base/blob/4a6b929c4e01a8d9ce1b3a0a1e4e6f4e6c16258a/src/lib/airGap.js#L6

The URL breaks this way: airgap-wallet://?d=com/airgap?d=UgoPLk4k...

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

AndreasGassmann commented 3 years ago

Thanks for the PR. Is this something that is not working at the moment?

We are currently working on a new version of our serializer (the old one will stay around for a while to not break backwards compatibility), and with that change, we want to improve the callback parameter anyway.

davidyuk commented 3 years ago

Is this something that is not working at the moment?

Yep, currently, Vault can't open Base aepp by universal link.

a new version of our serializer

Do you mean v3? We just noticed v2 😄