Add SegWit, PSBT and BC-UR v2 support - Githubissues

airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.

MIT License

386 stars 109 forks source link

Add SegWit, PSBT and BC-UR v2 support #73

Closed AndreasGassmann closed 2 years ago

AndreasGassmann commented 3 years ago

Coinlib

[x] To prepare a segwit/PSBT transaction, we need the masterFingerprint in the wallet. This should be added to all "share account" messages.
[x] Add signing support for PSBTs
[x] Add broadcast support for PSBTs
[x] Extract data (eg. input and output, signatures) from PSBT so we can display it. (partially done)

Apps

[x] "prepareTransaction" in the Wallet must be called with masterFingerprint

Other

[x] ~RBF (replace by fee) can now be configured, we need to add a UI for it~ (RBF can be done through watch-only wallets in the near future)

Watch-only wallets

[x] BlueWallet
[x] Sparrow

Other wallets that support BC-UR should also work, but will be tested in a separate issue: https://github.com/airgap-it/airgap-vault/issues/105

Originalimoc commented 3 years ago

Cool, looking forward to it🌝

AndreasGassmann commented 2 years ago

AirGap now supports SegWit. Support for watch-only wallets has been moved to a new issue: https://github.com/airgap-it/airgap-vault/issues/105

In the next Vault update, we should have a working beta.