docker build does not terminate

airgap-it / airgap-vault

The AirGap Vault is installed on a spare smartphone that has no connection to any network, thus it is air gapped. This app handles the private key.

MIT License

386 stars 109 forks source link

docker build does not terminate #77

Closed Giszmo closed 3 years ago

Giszmo commented 3 years ago

I just tried to reproduce the latest build and it got stuck on this line I think:

RUN echo y | $ANDROID_HOME/tools/bin/sdkmanager --update

To my surprise, hitting "y" worked. TIL: Docker build is interactive?

Either way, the approach that's more reliable is

RUN yes | $ANDROID_HOME/tools/bin/sdkmanager --update

AndreasGassmann commented 3 years ago

It's weird that this is an issue for you. We run this on our CI and we never had any issues.

It looks like the second version works as well, so we'll probably change it if that works better for you.

Giszmo commented 3 years ago

I'm not sure if the command maybe asked for two approvals and the simple echo thus went dry where the aggressive yes would have kept spamming or if it was a wild coincidence that the script stopped there for two minutes and just when I decided to hit "y" it finished whatever it was stuck with. As we will run the test script unattended soon, it would be appreciated to use what's more likely to work for all. Thanks.