search

airgap-it / airgap-wallet

The AirGap Wallet is installed on an everyday smartphone. This app has only access to public information.
MIT License
454 stars 128 forks source link

Uniswap, WalletConnect - Wallet does not implement EIP-712, eth_signTypedData_v4 #238

Closed chris-bbq closed 3 months ago

chris-bbq commented 9 months ago

Trying to swap back an ERC-20 Token to ETH on Uniswap.

Getting this error in JavaScript console in browser (Firefox and Brave):

"signTypedData: wallet does not implement EIP-712, falling back to eth_sign Missing or invalid. request() method: eth_signTypedData_v4"

Steps to reproduce:

URL: https://app.uniswap.org/swap

  1. Connect Airgap Wallet using WalletConnect
  2. Approve Token
  3. Swap Token not possible. Nothing pops up in wallet to confirm and sign the swap. In JavaScript console i get the error above.
mlaeng commented 9 months ago

Hey @chris-bbq may I ask which version of the AirGap Wallet you were using?

chris-bbq commented 8 months ago

Version 3.31.1

debeldami commented 3 months ago

@chris-bbq this should be working fine on iOS now though we still have an issue we have to fix on walletconnect compatibility for Android.