airgap-it / beacon-sdk

The beacon sdk allows developers of dApps and wallets on Tezos to implement the wallet interaction standard tzip-10.
https://walletbeacon.io
MIT License
101 stars 65 forks source link

Detection of state error broken #637

Closed klassare closed 11 months ago

klassare commented 11 months ago

Describe the bug (current behavior) Detection of state error is no longer working

To Reproduce Steps to reproduce the behavior:

  1. Go to example dapp, without a listener to 'ACTIVE_ACCOUNT_SET'
  2. Pair with Kukai
  3. Change active account from Kukai

Expected (correct) behavior The invalid state error should be shown

Environment Device: MacBook Pro OS: macOS Sonoma Browser: Chrome

Additional context Branch: feat/transport-kukai-wc2

IsaccoSordo commented 11 months ago

Hi @klassare, the deployed DApp testing client has an active subscription to ACTIVE_ACCOUNT_SET, this may be the cause why you are not seeing the alert with the error.

klassare commented 11 months ago

It's working now on HEAD