airgap-it / beacon-sdk

The beacon sdk allows developers of dApps and wallets on Tezos to implement the wallet interaction standard tzip-10.
https://walletbeacon.io
MIT License
101 stars 65 forks source link

Loader stuck on Kukai modal #677

Closed klassare closed 8 months ago

klassare commented 10 months ago

Describe the bug (current behavior) Loader gets stuck when trying to pair sometimes

To Reproduce Steps to reproduce the behavior:

  1. Click "permission request" and then 'Kukai'
  2. Click "Connect now"

Expected (correct) behavior Load should stop when there's an error in the pairing

Screenshots and/or logs Skärmavbild 2023-12-04 kl  18 39 05

Environment

Additional context Branch: feat/transport-kukai-wc2

IsaccoSordo commented 10 months ago

Hi @klassare, we now close the alert and resetting the state if the WalletConnect init fails. Addressed in https://github.com/airgap-it/beacon-sdk/pull/674/commits/e5ebbc4295a3ddb67cf534317aec9e4d571beb7e and https://github.com/airgap-it/beacon-sdk/pull/674/commits/8152ff7246341a0c7909f1d4faca731801c572f1 Deployed version available at: https://67f0a486d437e7b2d2b31497e18fecc13c1c9871--beacon-sdk.netlify.app/

IsaccoSordo commented 8 months ago

This issue is solved since v4.1.1