Closed emchristiansen closed 1 year ago
Thanks for the contribution :+1:
Will have a look at the changes later today.
I moved the cargo upgrade
commit to a different PR https://github.com/airgap-it/tezos-rust-sdk/pull/38. Updating dependencies can be a nightmare sometimes, this needs some testing first.
The remaining changes look good to me :+1:
Each commit's message is the command that was run to generate that commit.
Note, neither
cargo clippy --fix
norcargo +nightly fmt
should change any semantics.I did upgrade the packages using https://lib.rs/crates/cargo-edit, and everything still builds and all tests still pass.
BTW, you might want to add a commit-hook to automatically
clippy --fix
andfmt
the code.