search

airgradienthq / arduino

Firmware of open-source hardware air quality monitors AirGradient ONE (indoor) and AirGradient Open Air (outdoor).
https://www.airgradient.com/documentation/
Other
218 stars 115 forks source link

TVOC in display should be in all caps #139

Closed MallocArray closed 4 months ago

MallocArray commented 6 months ago

Like other sensor names, TVOC should be in all caps, not lower case.

It is an acronym and should be capitalized, as well as matching the formatting of all of the other displayed readings.

Also, I believe it should be VOC instead of TVOC, as that is what the manufacturer refers to it at: https://sensirion.com/products/catalog/SGP40/

airgradienthq commented 4 months ago

@pnt325 @MallocArray is correct. Please change the display unit from "tvoc" to "VOC".

pnt325 commented 4 months ago

@airgradienthq IMG_1324

MallocArray commented 4 months ago

I like the capitals.

Still think the spacing of the columns could be improved. No reason for all of the blank space to the right of VOC and PM2.5 could still use some extra room.

This is what my ESPHome firmware looks like (Top line wasn't included due to my camera shutter being too fast)

image

airgradienthq commented 4 months ago

@pnt325 Please also adjust the layout as @MallocArray suggests. Then make a new pull request.

pnt325 commented 4 months ago

d0bde8b4f6fc53a20aed

I update the layout for 4 character value of CO2 and 3 character value of PM.

MallocArray commented 4 months ago

I like it!

airgradienthq commented 4 months ago

@pnt325 Perfect. Let's go with that.

pnt325 commented 4 months ago

@airgradienthq Please check and aprrove PR #195