search

airgradienthq / arduino

Firmware of open-source hardware air quality monitors AirGradient ONE (indoor) and AirGradient Open Air (outdoor).
https://www.airgradient.com/documentation/
Other
218 stars 115 forks source link

Add combined `hybrid` led bar mode #198

Closed stablestud closed 3 months ago

stablestud commented 4 months ago

This commit adds an additional led mode for the AirGradient One devices. Its called hybrid and it combines the CO2 and PM2.5 led modes displaying the worst value of both.

This allows the user to immediately evaluate the current air quality with a single glance. CO2 and PM2.5 can be checked combined directly from it.

stablestud commented 4 months ago

Hi @pnt325 @airgradienthq I would like your input on this :)

Is such a feature in your view desired? For me it certainly is, because, as described, it gives the user direct information about the air quality across different air parameters

stablestud commented 4 months ago
One thing that could be improved are the LED levels. PM2.5 and CO2 have different count of LED levels and different colors: Led level CO2 PM2.5
1 G G
2 GG GG
3 YYY YYY
4 OOOO YYYY
5 OOOOO OOOOO
6 RRRRRR OOOOOO
7 RRRRRRR RRRRRRR
8 PPPPPPPP RRRRRRRR
9 PRPRPRPRP PPPPPPPPP
10 PRPRPRPRP

My suggestion would be to unify the led levels, as currently I simply compare the led levels and show the highest one. But hence the levels are not really the same the comparison is flawed. I would like to do that in another PR if that's acceptable.

stablestud commented 4 months ago

Before this feature can be added, the integration for HA and AG dashboard must also be updated first, as in my testing the HA integration fails if it receives a unknown ledBarMode value (hybrid)

Nevertheless I could successfully switch the led mode of the device with a local server json request. Seems to be working fine

curl -X PUT http://airsensor.internal/config -H "Content-Type: application/json" --data '{"ledBarMode":"hybrid"}'
pnt325 commented 4 months ago

hi @stablestud Thank for your info.

@airgradienthq please check this proposed.

airgradienthq commented 3 months ago

@stablestud thank you for this contribution.

I think we need more discussion on this as there have been other suggestions on this before. Some for example suggesting to show both PM and CO2 at the same time. Like user 5 LEDs for PM and 5 for CO2 etc.

Others wanted to add VOCs but some don't.

So I think there are many ideas out there that need to be discussed first. Because it is not easy to see on the monitor which mode is set, so the more modes we introduce the more confusion could be caused.

I will see if I can come up with a couple of suggestions and then the community can discuss in more detail.

pnt325 commented 3 months ago

Thanks @stablestud I will close the PR, feel free to open it if any update.