airjp73 / rvf

Easy form validation and state management for React and Remix
https://rvf-js.io
MIT License
840 stars 66 forks source link

[Bug]: import.meta on Cloudlfare still not working (see #89) #264

Closed saibotrellum closed 1 year ago

saibotrellum commented 1 year ago

Which packages are impacted?

What version of these packages are you using?

As @jamesarosen in #89 said, I can confirm import.meta, called by zustand, still throws the error described in #89 on cloudflare pages. See James' comment for details. Ignoring slight version changes, same goes here.

Only zustand uses import.meta (says search through ./build), and npm explain zustand says

zustand@4.3.6 node_modules/zustand zustand@"^4.3.0" from #remix-validated-form@4.6.10 node_modules/remix-validated-form remix-validated-form@"^4.6.10" from the root project peer remix-validated-form@"^4.x" from @remix-validated-form/with-zod@2.0.5 node_modules/@remix-validated-form/with-zod @remix-validated-form/with-zod@"^2.0.5" from the root project

Please provide a link to a minimal reproduction of the issue.

https://github.com/omarkhatibco/remix-cf-remix-validated-form

Steps to Reproduce the Bug or Issue

npm run dev

Expected behavior

Not show errors on popular development platform

Screenshots or Videos

No response

Platform

Cloudflare Local Wrangler

Additional context

No response

airjp73 commented 1 year ago

I noticed there's a solution given in the zustand repo for this issue. Does that fix the issue for you?

AhmedNawaf commented 1 year ago

I noticed there's a solution given in the zustand repo for this issue. Does that fix the issue for you?

I had the same issue and now It's working thanks.

airjp73 commented 1 year ago

I'm going to close this issue now as it seems like we have a working solution.