[Bug]: When a fetcher is supplied via the ValidatedForm, the non-js path stops working - Githubissues

airjp73 / rvf

Easy form validation and state management for React and Remix

https://rvf-js.io

MIT License

827 stars 66 forks source link

[Bug]: When a fetcher is supplied via the ValidatedForm, the non-js path stops working #273

Closed meza closed 1 month ago

meza commented 1 year ago

Which packages are impacted?

[X] remix-validated-form
[X] @remix-validated-form/with-zod
[ ] @remix-validated-form/with-yup
[ ] zod-form-data

What version of these packages are you using?

"remix-validated-form": "4.6.11",
"zod": "3.21.4"
"@remix-validated-form/with-zod": "2.0.5",

Please provide a link to a minimal reproduction of the issue.

https://codesandbox.io/s/epic-saha-u99g03?file=/app/routes/index.tsx

Steps to Reproduce the Bug or Issue

Keep Javascript on
leave the input field empty
submit the form
see the validation work
Turn JS off
leave the input field empty
see the validation NOT work
remove the fetcher from the ValidatedForm props
submit an empty field
the validation works

Expected behavior

I'd expect the validation to work with a custom fetcher

Screenshots or Videos

No response

Platform

Tried on win 11, latest firefox and chrome

Additional context

No response

airjp73 commented 1 month ago

RVF v6 has been released 🎉

Due to the extent of the rework in v6, I'm going to close this issue for now. If it's still a problem in that version, please feel free to open a new issue.

You can find the documentation here and the migration guide here.